Fix for rename #1478
Open
Fix for rename #1478
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names are stored in 3 locations (the main unit, historical figure, and soul), not 2 I think this is fine but if anything messes with current_soul then never mind - I have never had current_soul be changed to a seprate individual with a different name from the unit itself but I am new to the game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names are stored in 3 locations (the main unit, historical figure, and soul), not 2
I think this is fine but if anything in the vanilla game can cause current_soul to have a different name than the unit and historical figure, then never mind - I have never had current_soul be changed to a separate individual with a different name from the unit itself, but I am new to the game.